RFR: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
Conor Cleary
ccleary at openjdk.java.net
Mon Apr 12 15:27:50 UTC 2021
### Description
`Inet6Address/B6206527.java` test creates two instances of ServerSocket, both of which are explicity bound to a Link-Local address. Neither of the ServerSocket instances are explicitly closed meaning there is no guarantee that their associated resources are freed.
### Fix
Each ServerSocket is instantiated in a try-with-resources block. This ensures that in both cases of success or failure within the try-with-resources block, the sockets are always closed thanks to ServerSocket implementing Closeable. The test is also now started in othervm mode as an added assurance of the test's isolation in the event that resources are not freed.
-------------
Commit messages:
- 8264824: Removed erroneous whitespace
- 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
Changes: https://git.openjdk.java.net/jdk/pull/3437/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3437&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8264824
Stats: 12 lines in 1 file changed: 2 ins; 0 del; 10 mod
Patch: https://git.openjdk.java.net/jdk/pull/3437.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3437/head:pull/3437
PR: https://git.openjdk.java.net/jdk/pull/3437
More information about the net-dev
mailing list