RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v2]

Julia Boes jboes at openjdk.java.net
Mon Apr 26 17:27:56 UTC 2021


On Mon, 26 Apr 2021 14:25:50 GMT, Julia Boes <jboes at openjdk.org> wrote:

>> Add two static factory methods to com.sun.net.httpserver.Filter that facilitate the creation of pre- and post-processing Filters: 
>> 
>> `public static Filter beforeResponse(String description, Consumer<HttpExchange> filterImpl) {}`
>> `public static Filter afterResponse(String description, Consumer<HttpExchange> filterImpl) {}`
>
> Julia Boes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update specs and add test

> This looks a little odd - writing to the output steam before the response headers have been sent. Does it work because the length is actually 0? Please add some response body to the test, this should then show that writing to the output stream before the headers have been sent is an error.

Oops, that's fixed now!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3468


More information about the net-dev mailing list