RFR: 8265123: Add static factory methods to com.sun.net.httpserver.Filter [v4]

Michael McMahon michaelm at openjdk.java.net
Wed Apr 28 12:03:55 UTC 2021


On Wed, 28 Apr 2021 11:29:18 GMT, Julia Boes <jboes at openjdk.org> wrote:

>> Add two static factory methods to com.sun.net.httpserver.Filter that facilitate the creation of pre- and post-processing Filters: 
>> 
>> `public static Filter beforeResponse(String description, Consumer<HttpExchange> filterImpl) {}`
>> `public static Filter afterResponse(String description, Consumer<HttpExchange> filterImpl) {}`
>
> Julia Boes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update specs and small fix in test

Changes requested by michaelm (Reviewer).

src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java line 149:

> 147:      * operation.
> 148:      *
> 149:      * <p>The {@link #description() description} describes the returned filter.

Maybe, delete the first sentence here. I don't think it adds much value. Then the @param for description could say: The string to be returned from {@link #description()}

-------------

PR: https://git.openjdk.java.net/jdk/pull/3468


More information about the net-dev mailing list