RFR: 8266250: WebSocketTest and WebSocketProxyTest call assertEquals(List<byte[]>, List<byte[]>) [v3]

Daniel Fuchs dfuchs at openjdk.java.net
Thu Apr 29 14:14:18 UTC 2021


On Thu, 29 Apr 2021 11:38:21 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improved diagnostic message
>
> test/jdk/java/net/httpclient/websocket/WebSocketProxyTest.java line 179:
> 
>> 177:         var expected = ofBytes(b);
>> 178:         var problem = actual.equals(expected) ? "match" : "differ";
>> 179:         return "%s and %s %s".formatted(actual, expected, problem);
> 
> I would rename "problem" to more neutral "message" or "description". Ditto in the other file.

Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3776


More information about the net-dev mailing list