RFR: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order [v4]

Evan Whelan ewhelan at openjdk.java.net
Tue Aug 17 08:52:36 UTC 2021


> Hi all,
> 
> Please review this fix for which corrects the order in which field values are returned from the `HttpURLConnection.getHeaderFields` and `URLConnection.getRequestProperties` methods.
> 
> Currently, the implementation of these methods returns the values in reverse. This does not conform with the RFC2616 spec which outlines that the order of these field values should not be changed. 
> 
> Thanks,
> Evan

Evan Whelan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Changed spec text to make correct use of tags
 - Merge branch 'master' into JDK-8133686_MessageHeader
 - MessageHeaderTest add comma to copyright year
 - URLConnection doc fixes
 - 8133686:  8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order v2
 - 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2294/files
  - new: https://git.openjdk.java.net/jdk/pull/2294/files/4e0c96cb..160d9e33

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2294&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2294&range=02-03

  Stats: 1550176 lines in 16228 files changed: 796447 ins; 678052 del; 75677 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2294.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2294/head:pull/2294

PR: https://git.openjdk.java.net/jdk/pull/2294


More information about the net-dev mailing list