[External] : Re: Proposal - 8209137: Add ability to bind to specific local address to HTTP client

[Jaikiran Pai]

The main items that we discussed in this thread have now all been 
included in the PR, so I've opened it for a formal review through a RFR.

-Jaikiran

On 08/12/21 8:51 pm, Jaikiran Pai wrote:
> Hello Daniel,
>
> On 08/12/21 8:21 pm, Daniel Fuchs wrote:
>> Hi Jaikiran,
>>
>> On 08/12/2021 14:32, Jaikiran Pai wrote:
>>> Is that the reason why we would want to do this security check both 
>>> in localAddress() as well as build()? If so, would we even want to 
>>> do this security check when a request is issued using the sendXXX 
>>> methods, since those methods could again potentially be issued from 
>>> a different thread than the one that was used to build the client 
>>> itself.
>>
>> Yes. A builder can be used to build several HttpClient instance, and I
>> believe the capability should be attached to the HttpClient instance,
>> not to the builder itself.
>>
>> In other words the code that builds and first obtain a reference to the
>> HttpClient must have that capability.
>
> Thank you for that input. I have now updated the PR to do this check 
> in the HTTPClient instead of the builder and also added an @implSpec 
> to note this behaviour. Once this settles, I'll add some jtreg tests 
> with security manager installed.
>
> -Jaikiran
>