RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v5]

Daniel Fuchs dfuchs at openjdk.java.net
Mon Feb 1 16:56:04 UTC 2021


On Sat, 30 Jan 2021 10:24:05 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixup @bug in the tests
>
> src/java.base/share/classes/java/net/DatagramSocket.java line 223:
> 
>> 221:  *        to the address type of the multicast groups that the {@code DatagramSocket}
>> 222:  *        will join. This is similar to a {@code DatagramChannel} that would be created
>> 223:  *        using {@link DatagramChannel#open()}.
> 
> I think this paragraph might be confusing to readers. I think you just want to say that DatagramSocket does not support a way to specify the PF when creating the socket. Consequently the underlying socket may not correspond to the multicast groups that the DatagramSocket attempts to join.

Done. I have updated the PR and integrated your previous comments too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2312


More information about the net-dev mailing list