RFR: 8235139: Deprecate the socket impl factory mechanism [v2]

[Patrick Concannon]

On Thu, 4 Feb 2021 15:20:31 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - 8235139: Updated @deprecated text for setSocketFactory methods in Socket and ServerSocket
>>  - Merge remote-tracking branch 'origin/master' into JDK-8235139
>>  - 8235139: Remove the socket impl factory mechanism
>
> src/java.base/share/classes/java/net/Socket.java line 1755:
> 
>> 1753:      * @see        SecurityManager#checkSetFactory
>> 1754:      * @deprecated Use {@link SocketChannel}, or subclass {@code Socket}
>> 1755:      *    directly.
> 
> A better suggestion in the first line would be:
> 
> Use a {@link SocketFactory} and subclass {@code Socket} directly.

I've incorporated your suggestion now. See commit 3a89432

> src/java.base/share/classes/java/net/ServerSocket.java line 928:
> 
>> 926:      * @see        SecurityManager#checkSetFactory
>> 927:      * @deprecated Use {@link ServerSocketChannel}, or subclass {@code ServerSocket}
>> 928:      *    directly.
> 
> A better suggestion in the first line would be:
> 
> Use a {@link ServerSocketFactory} and subclass {@code ServerSocket} directly.

I've incorporated your suggestion now. See commit 3a89432

-------------

PR: https://git.openjdk.java.net/jdk/pull/2375