RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

Conor Cleary ccleary at openjdk.java.net
Thu Feb 18 10:14:45 UTC 2021


On Tue, 16 Feb 2021 13:37:20 GMT, Jamie Le Tual <github.com+55101029+jamieletual at openjdk.org> wrote:

> > I think that the changes are mostly good. I would like to try them out on my local system and our internal buildAndTest system.
> 
> Chris, were you able to test the patch?
> 
> Also if anyone has an idea as to the best way to unit test this, let me know; are there any other unit tests where the build can become a root user?

Hi @jamieletual, I'm currently investigating any possibilities in testing for this change. In the meantime however it could be good to change the title of the PR to "8257235: InetAddress.isReachable should use non-privileged ICMP sockets when available" as it appears to be an Integration blocker (see Integration Blocker section of first PR comment).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1502


More information about the net-dev mailing list