RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v2]
Jayashree S Kumar
github.com+31532647+jaysk1 at openjdk.java.net
Wed Jan 6 04:34:12 UTC 2021
> Issue
>
> https://bugs.openjdk.java.net/browse/JDK-8243376
>
> Problem
>
> The scenario is:
> - Some specified target hostname resolves to two IP addresses (always the same address pair).
> - The DNS resolved order of the two ip addresses changes (a usual LoadBalancer type behavior).
> - The CNAME of the two ip addresses differ.
>
> In SocketPermission class(void getIP() method), it internally resolves and saves only the first IP address resolved, not all the IP addresses resolved.
> - Depending on when the implier/implied SocketPermission hostname is resolved, the resolved addresses order differs, and the internally saved IP address mismatches, resulting on SocketPermission#implies() false.
>
>
> Michael McMahon kindly reviewed and suggested changes: https://mail.openjdk.java.net/pipermail/net-dev/2020-May/014001.html
Jayashree S Kumar has updated the pull request incrementally with one additional commit since the last revision:
Incorporated changes suggested by Vyom in testcase
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1916/files
- new: https://git.openjdk.java.net/jdk/pull/1916/files/e7c5f585..f5a2f88c
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=1916&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=1916&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/1916.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/1916/head:pull/1916
PR: https://git.openjdk.java.net/jdk/pull/1916
More information about the net-dev
mailing list