RFR: 8260043: Reduce allocation in sun.net.www.protocol.jar.Handler.parseURL [v2]

eirbjo github.com+300291+eirbjo at openjdk.java.net
Wed Jan 20 15:50:43 UTC 2021


On Wed, 20 Jan 2021 15:34:21 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> eirbjo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   As a part of the rename from "canonize" to "canonicalize", doCanonize should also be renamed. This was an oversight in the original PR.
>
> LGTM - just a small nit that you seem to have forgotten to change canonize to canonicalize in some places.

Newbie question: Is a copyright year updates required when code is simply moved around like this?

More specifically, is it required when strictly deleting code from a file, like ParseUtil in this case?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2167


More information about the net-dev mailing list