RFR: 8133686: HttpURLConnection.getHeaderFields and URLConnection.getRequestProperties methods return field values in reverse order [v2]

[Evan Whelan]

On Thu, 28 Jan 2021 17:02:31 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Evan Whelan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   URLConnection doc fixes
>
> src/java.base/share/classes/java/net/URLConnection.java line 596:
> 
>> 594:      * corresponding values, they must be returned in the order they were added,
>> 595:      * preserving the insertion-order.
>> 596:      *
> 
> Here the `@implSpec` is right because it describes how subclasses should implement the method.
> Maybe there should be an additional `@implNote` as well to describe what the default implementation does.
> 
>       * @implNote The default implementation of this method returns an empty map always.
> 
> The `@implNote` is useful for subclasses to decide whether they should override the default implementation.

Added, thanks Daniel

> src/java.base/share/classes/java/net/URLConnection.java line 1201:
> 
>> 1199:      * @implSpec The default implementation of this method should preserve insertion order when
>> 1200:      * multiple values are added for a given key. They must be
>> 1201:      * returned in the order they were added.
> 
> If we are speaking about what the default implementation actually does, then the conditional tense should be removed. And this should probably be an @implNote. 
> 
>      * @implNote The default implementation of this method preserves the insertion order when
>      * multiple values are added for a given key. The values are returned in the order they 
>      * were added.

This has been changed, thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/2294