RFR: 8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory [v2]

[Daniel Fuchs]

On Fri, 29 Jan 2021 18:02:25 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8237352: Evaluate how to write a custom DatagramSocket/MulticastSocket without using DatagramSocketImplFactory
>
> src/java.base/windows/classes/java/net/DefaultDatagramSocketImplFactory.java line 102:
> 
>> 100:             // Always use TwoStacksPlainDatagramSocketImpl since we need
>> 101:             // to support multicasting at DatagramSocket level
>> 102:             return new TwoStacksPlainDatagramSocketImpl(exclusiveBind && !isMulticast, isMulticast);
> 
> DualStackPlainDatagramSocketImpl will be orphaned, are you proposing to keeping it? At some point all of the old implementation will be removed anyway so maybe it will be removed then?

I was keeping it in case we wanted to try & upgrade it to support multicasting. I don't think we should bother doing that, given that, as you say, we want at some point in the future to remove the whole old implementation. So yes - my plan was to keep it around just in case, until we remove the whole old implementation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2312