RFR: 8269481: SctpMultiChannel never releases own file descriptor [v3]

[Alan Bateman]

On 01/07/2021 16:47, Brian Burkhalter wrote:
>
>
>> On Jul 1, 2021, at 1:17 AM, Alan Bateman <alanb at openjdk.java.net 
>> <mailto:alanb at openjdk.java.net>> wrote:
>>
>> It looks like you've changed some but not all cases. I realize 
>> ChannelState.UNINITIALIZED is not too interesting but further 
>> maintainers may wonder about it.
>
> I’m not seeing that I missed any cases. I don’t really want to get 
> into modifying the states in this PR.

I should have been clearer. Look at SctpServerChannelImpl.java L284 and 
SctpMultiChannelImpl.java L376.  SctpNet.close(fdVal) added with the 
patch added them them before setting the state. The suggestion in the 
previous comments was to insert the close after setting the state to 
KILLED in case the close fail (in some corner case).

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/net-dev/attachments/20210701/722020e6/attachment.htm>