RFR: 8269481: SctpMultiChannel never releases own file descriptor [v4]

Alan Bateman alanb at openjdk.java.net
Fri Jul 2 06:24:00 UTC 2021


On Thu, 1 Jul 2021 18:09:39 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Please review this change to the Unix implementations of `sun.nio.ch.sctp.Sctp*ChannelImpl#kill()` to close the socket if `state == ChannelState.UNINITIALIZED`.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8269481: Fix incorrect order of setting state to KILLED and closing the socket

The implementation changes in the latest round look fine.

I didn't study the test too closely I wonder about the reliability of using a hard coded port (12345) and using losf on an agent VM. I think it will minimally need to run in /othervm mode to avoid shimmer in the numbest of open file descriptors that might arise due to the tests that ran previously in the same VM.

-------------

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4621


More information about the net-dev mailing list