RFR: 8270553: Tests should not use (real, in-use, routable) 1.1.1.1 as dummy IP value

Alan Bateman alanb at openjdk.java.net
Tue Jul 27 09:21:28 UTC 2021


On Tue, 27 Jul 2021 08:09:13 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> But this rabbit hole excursion makes me think it would be better to just use the local loopback in these tests.

The test already attempts to connect to a server on the loopback address with setup that leads to the "no suitable proxy" scenario. I suspect the proposed patch is okay but I'd prefer to wait until @dfuch is back (Daniel has been doing a lot of work on test stability in this area and will probably want to run the change on a wide range of OS/configurations to check that it is stable).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4806


More information about the net-dev mailing list