[jdk17] Integrated: JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed with "SocketException: Cannot allocate memory"

[Mark Sheppard]

On Mon, 14 Jun 2021 15:28:01 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:

> JDK-8265369 [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed with "SocketException: Cannot allocate memory"
> 
> The test java/net/MulticastSocket/Promiscuous.java has been observed to fail on a regular basis on macosx-aarch.
> This is typically under heavy test load on a test machine. Analysis of the problem have
> shown that the setsockopt for joining a multicast group will intermittently fail with ENOMEM.
> 
> While analysis of test environment shows significant memory usage and some memory pressure, it is
> not excessive and as such it is deemed transition or temporary condition, such that a retry of the
> setsockopt system call, has been seen to mitigate the issue. This adds to the stability of the
> Promiscuous.java test and reduces test failure noise.
> 
> The proposed fix is in open/src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c
> in the mcast_join_leave function.  That is, if setsockopt to join an mcast group fails, and the errno == ENOMEM, 
> then re-invoke the setsockopt system call for joining a mcast group.
> The change has been applied as a conditional compilation.
> Additionally this change result in the Promiscuous.java test being removed from the
> ProblemList.txt.
> 
> Please oblige and review the changes for a fix of the issue JDK-8265369

This pull request has now been integrated.

Changeset: d8a0582a
Author:    Mark Sheppard <msheppar at openjdk.org>
URL:       https://git.openjdk.java.net/jdk17/commit/d8a0582a36340bcc65910f3a34132ec6e04e5d01
Stats:     22 lines in 2 files changed: 16 ins; 1 del; 5 mod

8265369: [macos-aarch64] java/net/MulticastSocket/Promiscuous.java failed with "SocketException: Cannot allocate memory"

Reviewed-by: dfuchs, michaelm, chegar

-------------

PR: https://git.openjdk.java.net/jdk17/pull/44