RFR: JDK-8243376: java.net.SocketPermission.implies(Permission p) spec is mismatching with implementation [v6]

Vyom Tewari vtewari at openjdk.java.net
Fri Mar 5 16:05:20 UTC 2021


On Fri, 5 Mar 2021 15:08:10 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Jayashree S Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code Review: Incorporated Indention correction, added getIP and updated try-catch inside for loop
>
> Changes requested by michaelm (Reviewer).

As you change equal & hashCode method, if possible can you please  add some additional  tests in "jdk/java/net/SocketPermission/Equals.java" just to make sure we test every corner case.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1916


More information about the net-dev mailing list