RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v2]

[Jonathan Dowland]

On Mon, 15 Mar 2021 12:53:11 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Jonathan Dowland has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
>
> src/java.base/unix/native/libnet/NetworkInterface.c line 813:
> 
>> 811:         addrP = addrP->next;
>> 812:         (*env)->DeleteLocalRef(env, iaObj);
>> 813:         (*env)->DeleteLocalRef(env, ibObj);
> 
> At the cost of duplicating the delete on ibObj, is it worth locating the DeleteLocalRef to directly after the SetObjectArrayElement (so as to make it a little easier to reason about whether the code has followed the set/delete pattern correctly) ?

Yes that makes a lot of sense to me. I've done that (and the other similar suggestion) and force-pushed. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2963