RFR: 8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll [v3]

Jonathan Dowland jdowland at openjdk.java.net
Tue Mar 16 14:12:47 UTC 2021


On Mon, 15 Mar 2021 17:10:14 GMT, Chris Hegarty <chegar at openjdk.org> wrote:

>> Jonathan Dowland has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   8187450: JNI local refs exceeds capacity warning in NetworkInterface::getAll
>
> src/java.base/windows/native/libnet/NetworkInterface.c line 677:
> 
>> 675:         (*env)->DeleteLocalRef(env, iaObj);
>> 676:         (*env)->DeleteLocalRef(env, ibObj);
>> 677:         (*env)->DeleteLocalRef(env, ia2Obj);
> 
> ia2Obj is not guaranteed to be set to a local reference, no? (if the address family is AF_INET6)

You're right. I've corrected that and made the same last-use/deleteRef locality change as in the UNIX code. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2963


More information about the net-dev mailing list