RFR: 8263442: Potential bug in jdk.internal.net.http.common.Utils.CONTEXT_RESTRICTED [v2]

Michael McMahon michaelm at openjdk.java.net
Thu Mar 18 12:16:04 UTC 2021


> Hi,
> 
> The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of regression failures, which turned out to be another bug exposed by this fix where HTTP/1.1 CONNECT requests with authentication were filtering out proxy authentication headers wrongly. This was because the HttpRequestImpl created for the repeated CONNECT was putting the system headers in the user headers area of the HttpRequestImpl. The fix for that is to supply the user and system headers direct to the place where the new HttpRequestImpl is created.
> 
> Thanks
> Michael

Michael McMahon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'master' into 8263442
 - Merge branch 'master' into 8263442
 - uncovered an existing bug in first commit. Fixed here
 - Fix for 8263442

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2977/files
  - new: https://git.openjdk.java.net/jdk/pull/2977/files/b73dfb73..0bcaa25a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2977&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2977&range=00-01

  Stats: 25188 lines in 1348 files changed: 20405 ins; 1802 del; 2981 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2977.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2977/head:pull/2977

PR: https://git.openjdk.java.net/jdk/pull/2977


More information about the net-dev mailing list