RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]
Jamie Le Tual
github.com+55101029+jamieletual at openjdk.java.net
Mon Mar 22 14:43:40 UTC 2021
On Fri, 19 Mar 2021 16:47:10 GMT, Chris Hegarty <chegar at openjdk.org> wrote:
>>> I think that the changes are mostly good. I would like to try them out on my local system and our internal buildAndTest system.
>>
>> Chris, were you able to test the patch?
>>
>> Also if anyone has an idea as to the best way to unit test this, let me know; are there any other unit tests where the build can become a root user?
>
> @jamieletual Are you willing, or have time to pick this PR up again? I'd like to move it forward. If not, then maybe I can find someone to move it forward ( with appropriate attribution to your already committed contributions ) ?
I am more solicited elsewhere than I thought I would be at the moment, but
yes, I will still run with this.
On Fri, 19 Mar 2021 at 12:47, Chris Hegarty ***@***.***>
wrote:
> @jamieletual <https://github.com/jamieletual> Are you willing, or have
> time to pick this PR up again? I'd like to move it forward. If not, then
> maybe I can find someone to move it forward ( with appropriate attribution
> to your already committed contributions ) ?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk/pull/1502#issuecomment-802968528>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ANEMMZPQPKUB2CKIX65HCLLTEN52BANCNFSM4UGK4QJQ>
> .
>
-------------
PR: https://git.openjdk.java.net/jdk/pull/1502
More information about the net-dev
mailing list