RFR: 8266897: com/sun/net/httpserver/FilterTest.java fails intermittently with AssertionError

Michael McMahon michaelm at openjdk.java.net
Tue May 18 08:16:48 UTC 2021


On Mon, 17 May 2021 09:53:06 GMT, Julia Boes <jboes at openjdk.org> wrote:

> The tests for `afterHandler` filters expect the filter operation to happen before the assertion. Very rarely this is not the case, the calling thread reads the response before the filter operation is executed, so the test value is not set before it is asserted. 
> This fix uses a `CompletableFuture` to ensure the test value has been updated before it is asserted.
> 
> While here, the change increases the thread-safety of the filter state of a context.

LGTM

-------------

Marked as reviewed by michaelm (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4050


More information about the net-dev mailing list