RFR: 8267353: java/net/SctpSanity.java fails due to Protocol not supported
Alan Bateman
alanb at openjdk.java.net
Wed May 26 14:08:12 UTC 2021
On Wed, 26 May 2021 03:54:14 GMT, Jie Fu <jiefu at openjdk.org> wrote:
> Hi all,
>
> java/net/SctpSanity.java fails on some of our test machines due to Protocol not supported.
> The reason is that the test fails to detect all the cases when a machine doesn't support SCTP.
>
> The fix just follows what are done in [1][2][3] to detect unsupported paltforms at the beginning.
>
> Thanks.
> Best regards,
> Jie
>
> [1] https://github.com/openjdk/jdk/blob/master/test/jdk/com/sun/nio/sctp/SctpMultiChannel/Util.java#L59
> [2] https://github.com/openjdk/jdk/blob/master/test/jdk/com/sun/nio/sctp/SctpServerChannel/Util.java#L59
> [3] https://github.com/openjdk/jdk/blob/master/test/jdk/com/sun/nio/sctp/SctpChannel/Util.java#L59
I think this looks okay and aligns with Util.isSCTPSupported in test/jdk/com/sun/nio/sctp. One thing that I'm not 100% sure about is why we have a sanity test in test/jdk/java/net, @ChrisHegarty may remember.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4199
More information about the net-dev
mailing list