Integrated: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
Patrick Concannon
pconcannon at openjdk.java.net
Mon Nov 1 17:16:20 UTC 2021
On Mon, 11 Oct 2021 09:42:12 GMT, Patrick Concannon <pconcannon at openjdk.org> wrote:
> Hi,
>
> Could someone please review my changes (and CSR) to drop support for pre JDK 1.4 `DatagramSocketImpl` implementations?
>
> These changes propose to drop support for `DatagramSocketImpls` that were compiled with JDK 1.3 or older, which do not have support for connected sockets, for peeking at received datagrams, and for joining and leaving a group at a specific interface. This support is legacy, and should be relatively safe to remove as such implementations do not compile with JDK 1.4 or newer.
>
> Finally, with this set of proposed changes, if you have an `oldImpl`, and don’t use connect, then the methods `joinGroup` and `leaveGroup` will throw `NoSuchMethodError`. However, the current behaviour in `DatagramSocketImpl` is to throw an `UnsupportedOperationsException` for a method not implemented. Should this set of changes update the `joinGroup` and `leaveGroup` methods in order to preserve this behaviour?
>
> CSR: https://bugs.openjdk.java.net/browse/JDK-8274633
>
> Kind regards,
>
> Patrick
This pull request has now been integrated.
Changeset: 97715440
Author: Patrick Concannon <pconcannon at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/977154400be786c500f36ba14188bff79db57075
Stats: 290 lines in 3 files changed: 197 ins; 78 del; 15 mod
8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
Reviewed-by: alanb, dfuchs, vtewari
-------------
PR: https://git.openjdk.java.net/jdk/pull/5887
More information about the net-dev
mailing list