RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v2]

[viretp]

On Tue, 16 Nov 2021 13:17:16 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Hi,
>> 
>> Please find enclosed a patch that solves an unexpected interaction between server-set cookies and user-set cookies in the `java.net.HttpClient`.
>> 
>> In JDK 12 we fixed [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow user-supplied header to take precedence over (that is, replace) system-headers. 
>> At the time the fact that server cookies would be added to the system-supplied headers by the `CookieHandler` (if present), and that a user-supplied cookie would therefore replace them (instead of simply appending to them)  was overlooked.
>> 
>> This fix proposes to restore the behavior of JDK 11 WRT to cookies - and arrange for user-supplied cookies to be appended to server-supplied cookies.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor cleanup

src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 38:

> 36: import java.util.Collections;
> 37: import java.util.List;
> 38: import java.util.Locale;

Is this new import for Locale really necessary? It seems to me that Locale is not used in the class?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6408