RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v3]

Daniel Fuchs dfuchs at openjdk.java.net
Thu Nov 18 19:49:23 UTC 2021


On Thu, 18 Nov 2021 12:04:01 GMT, Michael McMahon <michaelm at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More cleanup
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java line 124:
> 
>> 122:         // to the target server.
>> 123:         collectHeaders1(sb, uh, nocookies);
>> 124: 
> 
> I found this part of the change confusing, could I suggest that the comment below is changed to say:
> 
> // Gather all 'Cookie:' headers from the unfiltered system headers, and the user headers
> // and concatenate their values in a single line

Good point! Done.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6408


More information about the net-dev mailing list