RFR: 8274809: Update java.base classes to use try-with-resources [v4]
Andrey Turbanov
github.com+741251+turbanoff at openjdk.java.net
Wed Oct 6 20:37:30 UTC 2021
On Wed, 6 Oct 2021 16:00:26 GMT, Bradford Wetmore <wetmore at openjdk.org> wrote:
>> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8274809: Update java.base classes to use try-with-resources
>> fix review comments
>
> src/java.base/share/classes/sun/security/timestamp/HttpTimestamper.java line 115:
>
>> 113:
>> 114: // Send the request
>> 115: try (DataOutputStream output = new DataOutputStream(connection.getOutputStream())) {
>
> Please break this up so it doesn't have lines > 80. e.g.
>
> try (DataOutputStream output =
> new DataOutputStream(connection.getOutputStream())) {
>
> This makes side-by-side viewing very hard without a wider monitor.
>
> Thank you.
Update.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5818
More information about the net-dev
mailing list