RFR: 8273910: Redundant condition and assignment in java.net.URI

Daniel Fuchs dfuchs at openjdk.java.net
Wed Oct 6 20:41:07 UTC 2021


On Thu, 19 Aug 2021 19:08:59 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> 1. Assignment `ru.host = child.host;` is duplicated and hence redundant.
> 2. Condition `q > p` is always `true`, because it just bellow inverse check
> 
>                 if (q <= p)
>                     break;

The updated logic looks correct, and my tests (tier1,tier2,tier3) came back with no failure.
Reviewed.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5190


More information about the net-dev mailing list