RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v2]

Tue Oct 12 15:41:33 UTC 2021

On Tue, 12 Oct 2021 11:15:55 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> src/java.base/share/classes/java/net/DatagramSocketImpl.java line 105:
>> 
>>> 103:      *
>>> 104:      * @implSpec the default implementation of this method always throws {@code SocketException}
>>> 105:      *
>> 
>> The implementation change looks fine. For the implSpec then it might be simpler if you drop "always" from the sentence. Also minor nit is that you use "the default" in connect vs. "The default" in disconnect.
>
> The preferred style would be to start the sentence with a capital letter and end it with a period (unlike `@param`)

Javadoc updated as requested, see commit 67265bd

-------------

PR: https://git.openjdk.java.net/jdk/pull/5887