RFR: 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations [v2]

[Patrick Concannon]

On Tue, 12 Oct 2021 11:20:01 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - 8260428: Corrected javadoc typos; combined declaration and initialization of variables in DSI; refactored dummy impls in test
>>  - Merge remote-tracking branch 'origin/master' into JDK-8260428
>>  - 8260428: Drop support for pre JDK 1.4 DatagramSocketImpl implementations
>
> test/jdk/java/net/DatagramSocket/OldDatagramSocketImplTest.java line 165:
> 
>> 163:     }
>> 164: 
>> 165:     private class OldDatagramSocketImplWithValidConnect extends DatagramSocketImpl implements AutoCloseable {
> 
> Maybe this class could extend the previous one, that would remove some of the boiler plate code where dummy stub method implementations are the same.

Good idea. Updated as suggested, see commit 67265bd

> test/jdk/java/net/DatagramSocket/OldDatagramSocketImplTest.java line 231:
> 
>> 229:         }
>> 230:     }
>> 231: 
> 
> Maybe add a short one comment:
> 
> 
> // Overriding connect() to make it public so that it can be called
> // directly from the test code
> 
> 
> (and do the same for disconnect below)

Comment added. See commit 67265bd

-------------

PR: https://git.openjdk.java.net/jdk/pull/5887