RFR: 8275319 java.net.NetworkInterface throws java.lang.Error instead of SocketException [v3]

[Alan Bateman]

On Mon, 18 Oct 2021 16:57:10 GMT, Daniel Jeliński <duke at openjdk.java.net> wrote:

>> Per Java documentation, "[Error](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Error.java#L30) [..] indicates serious problems that a reasonable application should not try to catch". Failure to enumerate network interfaces or addresses is not a serious enough situation; many applications can recover from this pretty easily.
>> 
>> All native methods (except `init()`) in [NetworkInterface](https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/net/NetworkInterface.java#L436) are declared with `throws SocketException`, so throwing SocketExceptions instead of Errors will match the declared interface.
>> 
>> Unix version of [NetworkInterface](https://github.com/openjdk/jdk/blob/master/src/java.base/unix/native/libnet/NetworkInterface.c#L1189) already throws `SocketException`s in similar situations, and does not throw `Error` under any circumstances.
>> 
>> I searched the bug database and mail archives, but could not find any discussion on the topic; if there's a reason to keep throwing `Error`s, I couldn't find it.
>> 
>> `tier1` tests pass, `java.net` tests pass. No new regression tests as I couldn't find any list of steps to reproduce the problem.
>> 
>> I don't have write access to JBS. I could use some help with creating a ticket.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix crash on GetIpAddrTable error

src/java.base/windows/native/libnet/NetworkInterface_winXP.c line 123:

> 121:                 // not an error
> 122:                 *adapters = NULL;
> 123:                 return ERROR_SUCCESS;

Mapping ERROR_NO_DATA to ERROR_SUCCESS is probably correct here. Could this explain bug reports that seem to be from configurations with no IP addresses plumbed?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5956