RFR: 8275319 java.net.NetworkInterface throws java.lang.Error instead of SocketException [v4]

Daniel Fuchs dfuchs at openjdk.java.net
Wed Oct 20 13:58:06 UTC 2021


On Wed, 20 Oct 2021 13:38:17 GMT, Daniel Jeliński <duke at openjdk.java.net> wrote:

>> Hmm... JDK-8225239 might have introduced a bug. 
>> I see that with the current code neither `enumAddresses_win` nor `enumAddresses_win_ipaddrtable` will return -2 - so there appears to be some dead code. I suspect that this line here is wrong:
>>  https://github.com/openjdk/jdk/blob/a6c89e231872e7fab236ed87b5ccf44a189d6786/src/java.base/windows/native/libnet/NetworkInterface.c#L516
>>  it should be returning `ret` not `NULL`
>
> Thanks @dfuch and @AlanBateman for the review and all your help.
> 
> @dfuch I'd rather follow up on the remaining issues in a separate PR. This one is already doing more than the PR title advertises.

@djelinski I have no objection in handling that in a followup PR.
I have logged https://bugs.openjdk.java.net/browse/JDK-8275640.
Would you be willing to continue with that?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5956


More information about the net-dev mailing list