RFR: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel [v2]

[Daniel Fuchs]

On Mon, 13 Sep 2021 11:48:22 GMT, Masanori Yano <myano at openjdk.org> wrote:

>> Please review this change to the Unix implementations of sun.nio.ch.sctp.Sctp*ChannelImpl#implCloseSelectableChannel() 
>> to be same as SocketChannelImpl at JDK-7118373. (The preClose is missing a check for the ST_KILLED state.)
>
> Masanori Yano has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
>  - Merge branch 'master' of https://github.com/masyano/jdk into 8238274
>  - 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel

test/jdk/com/sun/nio/sctp/SctpChannel/CloseDescriptors.java line 29:

> 27:  * @summary Potential leak file descriptor for SCTP
> 28:  * @requires (os.family == "linux")
> 29:  * @run main CloseDescriptors

The test SctpMultiChannel/CloseDescriptors seems to work - at least it doesn't fail all the time - but it's using `@run main/othervm`. I believe you should make this test run in /othervm mode for more stability. I will test again with your later change and /othervm mode.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5274