RFR: JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests [v2]

Michael McMahon michaelm at openjdk.java.net
Wed Sep 29 11:05:33 UTC 2021


On Wed, 22 Sep 2021 21:05:34 GMT, Mahendra Chhipa <github.com+34924738+mahendrachhipa at openjdk.org> wrote:

>> Dependencies of TestHttpServre, HttpTransaction, HttpCallback are removed from following tests:
>> open/test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java
>> open/test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java
>> open/test/jdk/sun/net/www/protocol/http/RelativeRedirect.java
>> open/test/jdk/sun/net/www/protocol/http/B6296310.java
>
> Mahendra Chhipa has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Updated execution mode to othervm to resolve cleaning up thread issue.
>  - Merge branch 'master' into JDK-8273142
>  - JDK-8273142 : Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests

Changes requested by michaelm (Reviewer).

test/jdk/sun/net/www/protocol/http/B6296310.java line 103:

> 101:          try(PrintWriter pw = new PrintWriter(trans.getResponseBody())) {
> 102:             pw.print("");
> 103:          }

Not sure what the purpose of this block is, which apparently writes no bytes to the OutputStream?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5352


More information about the net-dev mailing list