RFR: JDK-8280498: jdk/java/net/Inet4Address/PingThis.java fails on AIX [v5]
Michael Felt
duke at openjdk.java.net
Sat Apr 30 09:43:42 UTC 2022
On Fri, 29 Apr 2022 14:16:54 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:
>> Michael Felt has updated the pull request incrementally with one additional commit since the last revision:
>>
>> missing semi-colon
>
> The changes looks ok to me given that the test can be compiled and executed with no failures.
> The following question being asked before ,but is there a reason why we check platform in the test code, instead of using [requires jtreg tag](https://openjdk.java.net/jtreg/tag-spec.html#requires_names) ?
> The following requires tag could be used as a replacement for the proposed change:
>
> * @requires (os.family != "windows" & os.family != "aix")
@AlekseiEfimov - that is, imho, a more elegant way to skip tests. I'll look for an example elsewhere and make the change.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7013
More information about the net-dev
mailing list