RFR: 8291956: Simplify the loop condition in sun.net.httpserver.Request constructor [v3]

thyecust duke at openjdk.org
Fri Aug 5 14:06:42 UTC 2022


On Fri, 5 Aug 2022 13:36:47 GMT, thyecust <duke at openjdk.org> wrote:

>> The condition at line 57 (after while) will evaluate to false
>> if startLine == null, so the previous if-condition is covered.
>
> thyecust has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into if
>  - update the Copyright year
>  - simplify loop contidition
>  - Merge branch 'openjdk:master' into if
>  - remove redundant if-condition after readLine()
>    
>    The condition at line 57 (after while) will evaluate to false
>    if startLine == null, so the previous if-condition is covered.

Thanks for review.

I run `make test-tier2` and got an error:


...
Compiling 8 files for jdk.unsupported.desktop
In file included from /home/tianh/github/jdk/src/hotspot/share/utilities/globalDefinitions_gcc.hpp:35,
                 from /home/tianh/github/jdk/src/hotspot/share/utilities/globalDefinitions.hpp:35,
                 from /home/tianh/github/jdk/src/hotspot/share/memory/allocation.hpp:29,
                 from /home/tianh/github/jdk/src/hotspot/share/classfile/classLoaderData.hpp:28,
                 from /home/tianh/github/jdk/src/hotspot/share/precompiled/precompiled.hpp:34:
In function 'const void* memchr(const void*, int, size_t)',
    inlined from 'int SignatureStream::scan_type(BasicType)' at /home/tianh/github/jdk/src/hotspot/share/runtime/signature.cpp:343:32,
    inlined from 'void SignatureStream::next()' at /home/tianh/github/jdk/src/hotspot/share/runtime/signature.cpp:373:19,
    inlined from 'void SignatureIterator::do_parameters_on(T*) [with T = Fingerprinter]' at /home/tianh/github/jdk/src/hotspot/share/runtime/signature.hpp:635:41,
    inlined from 'void SignatureIterator::do_parameters_on(T*) [with T = Fingerprinter]' at /home/tianh/github/jdk/src/hotspot/share/runtime/signature.hpp:629:6,
    inlined from 'void Fingerprinter::compute_fingerprint_and_return_type(bool)' at /home/tianh/github/jdk/src/hotspot/share/runtime/signature.cpp:169:19:

-------------

PR: https://git.openjdk.org/jdk/pull/9571


More information about the net-dev mailing list