RFR: 8291637: HttpClient default keep alive timeout not followed if server sends invalid value [v2]
Michael McMahon
michaelm at openjdk.org
Fri Aug 5 14:36:08 UTC 2022
On Fri, 5 Aug 2022 12:53:22 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Michael McMahon has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update from Jai's review
>
> test/jdk/sun/net/www/http/KeepAliveCache/B8291637.java line 61:
>
>> 59: try {
>> 60: serverSocket.close();
>> 61: s.close();
>
> Could that trigger a NPE if `s` is null?
That could happen only if `ServerSocket.accept` throws an exception, which I guess is possible. But, the client side would not get to call `Server.close` then. I'll add a check anyway.
-------------
PR: https://git.openjdk.org/jdk/pull/9755
More information about the net-dev
mailing list