RFR: 8272702: Resolving URI relative path with no / may lead to incorrect toString [v4]
Daniel Fuchs
dfuchs at openjdk.org
Thu Aug 11 14:13:35 UTC 2022
On Tue, 9 Aug 2022 11:02:31 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:
>> Consider an authority component without trailing "/" as a base URI. When resolving a relative path against this base URI, the resulting URI is a concatenated URI without "/".
>> This behaviour should be fixed, which is rationalized by rfc3986#section-5.2.3.
>> Could you review this fix?
>
> KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
>
> 8272702: Resolving URI relative path with no / may lead to incorrect toString
I agree with Michael. I did a deep dive in the URI code and conducted some experiments with the proposed fix and am happy with the results. I also double checked with the JCK tests for api/java_net and they were still happy. I believe this is good to go. Thanks for persisting with this one!
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/8899
More information about the net-dev
mailing list