RFR: 8292381: java/net/httpclient/SpecialHeadersTest.java fails with "ERROR: Shutting down connection: HTTP/2 client stopped"

[Jaikiran Pai]

On Wed, 17 Aug 2022 17:06:12 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

> Please find here a change that improves SpecialHeadersTest. This test creates a large amount of ephemeral clients and has been observed running out of heap space in our CI once. This change updates the test to wait for the previous HttpClient to be eligible for garbage collection before it creates a new one. It also verifies that no outstanding operation are still running on the client by the time the client is released.

test/jdk/java/net/httpclient/SpecialHeadersTest.java line 385:

> 383:         final URI uri = URI.create(uriString);
> 384: 
> 385:         HttpClient client = newHttpClient("testHomeMadeIllegalHeader", sameClient);

Previously before this change, this test method wasn't using the `sameClient` param while creating the new client and instead was creating it always. I don't know if that was intentional (in fact it wasn't even using the `headerNameAndValue` param being passed to it). Is this change to use the `sameClient` param while creating this client here, intentional?

-------------

PR: https://git.openjdk.org/jdk/pull/9908