RFR: JDK-8292586: simplify cleanups in NTLMAuthSequence getCredentialsHandle

Michael McMahon michaelm at openjdk.org
Thu Aug 18 11:03:18 UTC 2022


On Thu, 18 Aug 2022 10:03:23 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> NTLMAuthSequence getCredentialsHandle has a number of cleanup paths doing various JNU_ReleaseStringPlatformChars calls; those could be placed at one place in the function.

Looks good. Minor suggestion that the check in line 144 be changed to:

if (ss == SEC_E_OK) {

which complements the change to the initialization of variable ss.

-------------

Changes requested by michaelm (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9914


More information about the net-dev mailing list