RFR: 7113208: Incorrect javadoc on java.net.DatagramPacket.setLength() [v2]

Jaikiran Pai jpai at openjdk.org
Fri Aug 26 09:55:11 UTC 2022


> Can I please get a review of this javadoc only change for `DatagramPacket#setLength()` method? This addresses https://bugs.openjdk.org/browse/JDK-7113208.
> 
> I haven't create a CSR because the javadoc was already stating the correct behaviour in the `@throws` documentation as follows:
> 
>> @throws  IllegalArgumentException    if the length is negative,
>      *          or if the length plus the offset is greater than the
>      *          length of the packet's data buffer.
> 
> This commit merely fixes the main part of the javadoc.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  implement review comment

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10037/files
  - new: https://git.openjdk.org/jdk/pull/10037/files/9bfb59ff..addffb27

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10037&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10037&range=00-01

  Stats: 6 lines in 1 file changed: 2 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/10037.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10037/head:pull/10037

PR: https://git.openjdk.org/jdk/pull/10037


More information about the net-dev mailing list