RFR: 8291226: Create Test Cases to cover scenarios for JDK-8278067 [v3]
Ramesh Bhagavatam Gangadhar
rgangadhar at openjdk.org
Fri Aug 26 17:33:07 UTC 2022
On Mon, 22 Aug 2022 17:50:09 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Ramesh Bhagavatam Gangadhar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update and rename KeepAliveTest to KeepAliveTest.java
>>
>> 1. Increased space from 2 to 4.
>> 2. skipped test scenarios from 113 to 128 && 145 to 160
>
> test/jdk/sun/net/www/http/HttpClient/KeepAliveTest.java line 287:
>
>> 285: SERVER_100 + CLIENT_SEPARATOR + PROXY_200_NEGATIVE, SERVER_100_NEGATIVE + CLIENT_SEPARATOR + PROXY_200
>> 286: };
>> 287: private String[] clientScenarios = {
>
> should be final
changed to static final. thanks @dfuch
> test/jdk/sun/net/www/http/HttpClient/KeepAliveTest.java line 299:
>
>> 297: a[0] , a[1], a[2], a[3], a[4], a[5], a[6], a[7], a[8], a[9], a[10], a[11], a[12], a[13], a[14], a[15],
>> 298: };
>> 299: private int[] expectedValues = {
>
> should be final
changed to private static final int[]
thanks @dfuch
> test/jdk/sun/net/www/http/HttpClient/KeepAliveTest.java line 311:
>
>> 309: 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
>> 310: };
>> 311: private CountDownLatch countDownLatch = null;
>
> should be final and initialized to `new CountDownLatch(1);`
done thanks @dfuch
-------------
PR: https://git.openjdk.org/jdk/pull/9958
More information about the net-dev
mailing list