RFR: 8291226: Create Test Cases to cover scenarios for JDK-8278067 [v16]

[Michael McMahon]

On Mon, 29 Aug 2022 14:26:09 GMT, Ramesh Bhagavatam Gangadhar <rgangadhar at openjdk.org> wrote:

>> There are total 160 scenarios written with combination of client properties (Client Scenarios) and Server Response (Server Scenarios).
>> 
>> In tabular format, Client and Server scenarios along with expected output are documented here:[Permalink](https://bugs.openjdk.org/browse/JDK-8291226?focusedCommentId=14519074&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14519074)
>> 
>> This Program Should be run mandatorily in othervm mode itself since it has system property changes so can't be clubbed with other scenarios. so each scenario should be run in individual JVM.
>> 
>> For each and every scenario, ServerSocket is created and waits for clients to connect to it.
>> isProxySet and serverReady are shared variables between server thread and client thread(main) and it should be set and reset to false for each and every scenario.
>> 
>> isProxySet and serverReady variables should be set by server thread before proceeding to client thread(main).
>> 
>> if isProxySet variable is set to true then client set the proxy value to url.openConnection(Proxy)
>> <SNIPPET>
>> if (isProxySet) { 
>>          httpUrlConnection = (sun.net.www.protocol.http.HttpURLConnection) url .openConnection(new Proxy(Type.HTTP, new InetSocketAddress("localhost", SERVER_PORT))); } 
>> else { 
>>         httpUrlConnection = (sun.net.www.protocol.http.HttpURLConnection) url.openConnection(); 
>> }
>> </SNIPPET>
>> 
>> Program tries to fetch the Value of <Key, Value> Pairs of HashMap KeepAliveCache where Key is KeepAliveKey and Value is ClientVector KeepAliveTimeout is stored in Value ClientVector of HashMap KeepAliveCache.
>> 
>> if connection is cached then KeepAliveTimeout is stored in ClientVector. KeepAliveTimeout stored in Value(ClientVector) of HashMap KeepAliveCache is compared with Expected Value.
>> 
>> if connection is not cached then connection is terminated immediately.
>
> Ramesh Bhagavatam Gangadhar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update KeepAliveTest.java
>   
>   updated description for methods

test/jdk/sun/net/www/http/HttpClient/KeepAliveTest.java line 192:

> 190:  * @run main/othervm KeepAliveTest 159
> 191:  */
> 192: import java.nio.charset.StandardCharsets;

A blank line between 191 and 192 would be useful here and between 216 and 217, and generally between the end of each method and the start of the comment for the next method or set of definitions.

Also would it be possible to add the server scenario letter A-I into the big comment table that describes each client and server scenario? That would help understanding each test scenario by looking in one place.

-------------

PR: https://git.openjdk.org/jdk/pull/9958