RFR: 8297822: De-duplicate code in module jdk.sctp [v3]

Per Minborg pminborg at openjdk.org
Thu Dec 1 11:25:28 UTC 2022


> This PR proposes merging logic and optimising three classes that exist for aix, maces and windows.
> 
> Optimisation will reduce byte code. Below is an example for one of the many methods optimised.
> 
> Before:
> 
> public void implCloseSelectableChannel() throws java.io.IOException;
>   Code:
>      0: new           #7                  // class java/lang/UnsupportedOperationException
>      3: dup
>      4: ldc           #11                 // String SCTP not supported on this platform
>      6: invokespecial #13                 // Method java/lang/UnsupportedOperationException."<init>":(Ljava/lang/String;)V
>      9: athrow
> 
> 
> After:
> 
> public void implCloseSelectableChannel() throws java.io.IOException;
>   Code:
>      0: invokestatic  #16                 // Method sun/nio/ch/sctp/UnsupportedUtil.sctpUnsupported:()Ljava/lang/UnsupportedOperationException;
>      3: athrow

Per Minborg has updated the pull request incrementally with one additional commit since the last revision:

  Move and refactor classes to reduce duplication

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11436/files
  - new: https://git.openjdk.org/jdk/pull/11436/files/b73819f3..6c5c1f41

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11436&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11436&range=01-02

  Stats: 1101 lines in 15 files changed: 378 ins; 723 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/11436.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11436/head:pull/11436

PR: https://git.openjdk.org/jdk/pull/11436


More information about the net-dev mailing list