RFR: 8297778: Modernize and improve module jdk.sctp [v8]
Daniel Fuchs
dfuchs at openjdk.org
Thu Dec 1 15:36:31 UTC 2022
On Thu, 1 Dec 2022 15:02:45 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes a variety of modernisations to the `jdk.sctp` module.
>>
>> During the fix of https://bugs.openjdk.org/browse/JDK-8296024, several improvement areas were identified including:
>>
>> * Replacing duplicate code segments
>> * Making certain fields final
>> * Using enhanced switch
>> * Using records
>> * Fixing typos
>> * Marking fields participating in serialisation with `@Serial`
>> * Modernizing toString() implementations
>> * Using pattern matching
>> * Using diamond operators
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>
> Add import
Overall this looks like a good cleanup. Please do not integrate before running all related tests + tier1 and tier2.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11418
More information about the net-dev
mailing list