RFR: 8294047: HttpResponseInputStream swallows interrupts [v9]

Daniel Fuchs dfuchs at openjdk.org
Mon Dec 5 13:23:13 UTC 2022


On Mon, 5 Dec 2022 07:15:41 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   check thread interrupt status is set
>
> src/java.net.http/share/classes/java/net/http/HttpResponse.java line 1181:
> 
>> 1179:          * from being reused for subsequent operations.
>> 1180:          *
>> 1181:          * @implNote The read method of the default implementation returned
> 
> Hello Darragh, should we instead reword this as:
> 
>> @implNote The {@code read} method of the {@code InputStream} returned by the default implementation of this method will throw an {@code IOException} with the {@link Thread#isInterrupted() thread interrupt status set} if the thread is interrupted while blocking on read. In that case, the request will also be cancelled and the {@code InputStream} will be closed.
> 
> Additionally, irrespective of whether or not we decide to reword this, this file will need an update for the copyright year.

Agreed but it should be `{@linkplain Thread#isInterrupted() thread interrupt status set}`

-------------

PR: https://git.openjdk.org/jdk/pull/11323


More information about the net-dev mailing list