RFR: 8294047: HttpResponseInputStream swallows interrupts [v10]

Jaikiran Pai jpai at openjdk.org
Tue Dec 6 01:46:12 UTC 2022


On Mon, 5 Dec 2022 17:07:44 GMT, Darragh Clarke <duke at openjdk.org> wrote:

>> Currently if a `HttpResonseInputStream` gets interrupted while reading it will just swallow the exception and continue,
>> 
>> This PR changes it to close the stream and throw an IOException, I added a test to cover this which just uses two threads to read the stream then interrupt it.
>
> Darragh Clarke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   cleanup

Thank you for these changes Darragh. Looks fine to me. There was one review comment by Daniel where he noted that the fields of the `Handler` in the test should be `final` (which I agree with). From what I can see, that hasn't been addressed in the updates. In the current test, it doesn't functionally impact anything, so it is OK if you want to leave it in this form.

-------------

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11323


More information about the net-dev mailing list