RFR: 8281236: (D)TLS key exchange named groups [v4]

Sean Mullan mullan at openjdk.org
Tue Dec 6 16:55:18 UTC 2022


On Tue, 6 Dec 2022 07:58:02 GMT, Xue-Lei Andrew Fan <xuelei at openjdk.org> wrote:

>> This update is to support key exchange named groups customization for individual (D)TLS connection. Please review the CSR as well:
>> CSR: https://bugs.openjdk.org/browse/JDK-8291950
>> RFE: https://bugs.openjdk.org/browse/JDK-8281236
>> Release-note: https://bugs.openjdk.org/browse/JDK-8291975
>> 
>> This is an effort similar to [JDK-8280494: "(D)TLS signature schemes"](https://bugs.openjdk.org/browse/JDK-8280494)
>
> Xue-Lei Andrew Fan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - check duplicate
>  - Merge
>  - Merge
>  - Merge
>  - add test cases
>  - 8281236: (D)TLS key exchange algorithms

test/jdk/javax/net/ssl/SSLParameters/NamedGroupsSpec.java line 27:

> 25:  * @test
> 26:  * @bug 8281236
> 27:  * @summary (D)TLS key exchange named groups

Can you write a more specific summary of what this test is testing? The @summary doesn't have to match the bug title (and often should not IMO). Since this doesn't test DTLS, that should not be included.

Same comment for the other tests.

-------------

PR: https://git.openjdk.org/jdk/pull/9776


More information about the net-dev mailing list