RFR: 8298340: java/net/httpclient/CancelRequestTest.java fails with AssertionError: Found some subscribers for testPostInterrupt [v2]

Daniel Fuchs dfuchs at openjdk.org
Thu Dec 8 15:20:47 UTC 2022


> There are several ways by which an HTTP/2  stream can be closed. Due to the built-in asynchronous behavior, and to avoid unnecessary churn when a request is cancelled/aborted there are two places where the boolean stream's state `closed` can be set to true: `cancelImpl` and `close`. The current code completes the subscriber in `cancelImpl`, but the subscriber should also be completed in `close`. The intermittent failure happens if `close` gets ever called before `cancelImpl`.
> This patch fixes that.

Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:

  Fix typo

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11595/files
  - new: https://git.openjdk.org/jdk/pull/11595/files/d77aacee..02530e7a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11595&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11595&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/11595.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11595/head:pull/11595

PR: https://git.openjdk.org/jdk/pull/11595


More information about the net-dev mailing list